IF: Check if input strings are invalid in conversion to public key or signature #1606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
approved these changes
Sep 7, 2023
There was a problem hiding this comment.
It would be nice to have a test that triggers this failure. I looked around some but couldn't find any examples. Maybe @mschoenebeck could provide an example.
greg7mdp
approved these changes
Sep 7, 2023
greg7mdp
reviewed
Sep 7, 2023
| @@ -17,7 +17,7 @@ namespace fc::crypto::blslib { | |||
|
|
|||
| std::array<uint8_t, 192> bytes = fc::crypto::blslib::deserialize_base64<std::array<uint8_t, 192>>(data_str); | |||
|
|
|||
| constexpr bool check = false; // default | |||
| constexpr bool check = true; // check if base64str is invalid | |||
| constexpr bool raw = true; | |||
| std::optional<bls12_381::g2> g2 = bls12_381::g2::fromAffineBytesLE(bytes, check, raw); | |||
There was a problem hiding this comment.
Not related to this PR, but I don't think the APIs from bls12_381 are well designed. These bool parameters could be replaced by enum template parameters which would be clearer and more efficient.
|
Note:start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a string is converted to a public key or signature, check if the string is invalid.