Use a single WASM interface per nodeos (instead of per thread) to save WASM compile time and cache #1549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…asm_interface_collection.cpp; simplify multi-threading wasm_interface code significantly
This was referenced Aug 23, 2023
heifner
requested changes
Aug 24, 2023
heifner
approved these changes
Aug 31, 2023
…aring of compiled mod in backend)
spoonincode
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A part of eosnetworkfoundation/product#149.
Currently when read-only threads are enabled, each thread maintains its own WASM interface which in turn keeps its own instantiated module cache. This leads to
wasm_interface_collectionhad to be introduced to hide the complicated logic to manage WASM interface on the main thread and the read-only threads.This PR changes to use a single WASM interface per nodeos, resolving all the three issues mentioned above.