Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotstuff integration #1536
Hotstuff integration #1536
Changes from 64 commits
28d7cbf
a9058bd
75b5627
d08e321
bac10e1
b432deb
71ea20c
4f8a5c4
900fa22
0bda766
54797c0
31e4100
84c80f9
3db6e06
8635f39
8067149
66885fe
91cbeac
98c08c3
1e0ca13
23fbe2d
55717d1
03ac11e
a3a0a6f
ad09408
fe11657
ef9d7e3
b73937f
46cefb5
bc5ba05
5722be9
b8a772c
f00fd32
beed426
0a789b0
50fdb40
3c19387
dadd077
9c70367
52eb338
d53d431
0a9f0c1
84cc1f7
b624c24
d19c3f0
5804b24
aada30c
30a61cc
3efd4bf
26d82da
bbe8735
b1b9642
35839ed
b4c445d
528c089
fbe6455
0c6d290
51feb05
6cfb3fb
79142ab
2799ca7
5e895c4
7a22f7e
493b7e1
26f72bd
1b92f02
cc65791
78bbc62
b9ac212
be96431
988261e
32258f4
dac12e5
f576797
eb2fc59
54e88ed
cce8e5c
1b0a63b
c775d7a
f7364c5
1b7351d
6f47ddb
6bb9d36
1056702
e421b74
417615d
86a0b28
3b3fb28
1fdd181
35a040d
f412147
5c82eec
0fd2540
b280344
e92e4ad
dc029db
97df979
21de5c4
3a65b3f
20520cc
4bd9b4d
383c6e9
f1a1893
39cd75a
a2013f7
7bab066
eb3e2dd
aea1aa1
2686c85
61afa39
8381b40
86432e9
e8d10a3
80c3b22
fe71f93
81ede3c
e7e9a7c
ba33ba8
1cd0b35
bf04b0a
37c3322
57b61b9
93905c3
ae08070
f0038dc
dd8d988
aaa9284
86cca8e
f68869a
9480cf8
4a5bc73
789dfee
51e9379
acc51cb
9cc6f74
30fd771
f0fcc44
7bb4e56
fd02885
afd97ca
bcb2545
a09fd7d
8ea41a4
8a7794f
809e4ab
d8e7ee5
e384b43
0d809ef
1eb7bc0
38562ac
25b93a9
d2f1c92
70fb9a9
1ced859
57bf131
12e6a53
da5d431
ceec40b
be4c877
2c4cb49
67c4f1d
a241785
209090e
46867a9
3562c7d
8ed91d9
fb6f69e
49aca0b
5b83d32
264dffe
0663a3d
08c5186
ac2f980
b5f522f
c300efe
198e512
89e3d8d
b86a162
f2a3c27
808d586
95f06f2
20f5d0e
064717e
54e5d70
82178a7
f44409b
d4d052e
8c03a62
ad64fc7
755da1a
f622184
a19d126
548641d
cf7f527
c40d390
3887b2c
753af58
9daa3d2
cc56c51
da5f812
4b06a17
bd43d61
c10bcaa
ccc79c5
c84bab1
cf50336
facbee8
5cce3d6
eb84aa2
053fe72
68148eb
78c6de1
f02fa48
a9987a2
773577b
4066109
486fed3
9411c05
3465884
0c82e7a
b9deb58
8a7b973
274e44a
93163ec
2e49794
4c3535f
08d0c96
112bb69
84098e5
66c7c62
914f218
5e9af0c
2449830
e464aee
a74450c
cafd0b6
302b957
be77ca6
23945ff
ba5006e
9de11ff
8e98c18
a9058a1
6d64c27
6bd8128
c54fe32
232e95b
33210c0
5cc1b87
f9786e1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we want this header file in
libraries/chain/include/eosio/chain
but not inlibraries/hotstuff/include
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the
bls_pub_keys
be added in theproducer_authority_schedule
instead of on the side like here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extended schedule was a placeholder until we reached a decision on the final format of the finalizers set structure. I think we agreed to only keep the bls public key, as well as the threshold for finalizers (as far as the hotstuff algorithm is concerned). The name would be present in the structure as well, but serves only to identify the finalizer on-chain, and is not required by Hotstuff.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All these
= NULL_PROPOSAL_ID
are unneeded since the default construction of sha256 already initializes to all zeroes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add some explanation about instant_finality like other protocol features do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am a little puzzled by
chain
being a part of those two file names, and one havingchain
in the front and the other in the end:chain_pacemake.cpp
andqc_chain.cpp
. Can the names be changed?