Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python test shutdown on errors #2165

Closed
heifner opened this issue Jan 30, 2024 · 0 comments · Fixed by #2192
Closed

Python test shutdown on errors #2165

heifner opened this issue Jan 30, 2024 · 0 comments · Fixed by #2192
Assignees
@heifner
Labels
👍 lgtm OCI Work exclusive to OCI team

Comments

@heifner
Copy link
Member

heifner commented Jan 30, 2024

Been seeing timeouts in our integration tests. These timeouts appear to be caused by not shutting down the cluster of nodeos that are running. This PR #1182 moved shutdown of Cluster to a atexit.register call. Unfortunately, that is not called if a test exits due to an error or if os.exit() is called directly.

Seems we need to revert back to TestHarness.shutdown() calling Cluster.shutdown() instead of using atexit.register.
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Jan 30, 2024
@heifner heifner mentioned this issue Jan 30, 2024
Closed
heifner added a commit that referenced this issue Jan 31, 2024
@heifner
GH-2165 Use explicit shutdown of cluster as atexit doesn't work on er…
69e42b6 
…rors
heifner added a commit that referenced this issue Feb 2, 2024
@heifner
GH-2165 Explicit shutdown since atexit not called on error
de910b9
@heifner heifner mentioned this issue Feb 2, 2024
Merged
@arhag arhag added 👍 lgtm and removed triage labels Feb 2, 2024
heifner added a commit that referenced this issue Feb 3, 2024
@heifner
Merge pull request #2192 from AntelopeIO/GH-2165-cluster-shutdown
6fb3fe6 
Tests: Explicit shutdown since atexit not called on error
@github-project-automation github-project-automation bot moved this from Todo to Done in Team Backlog Feb 3, 2024
@heifner heifner self-assigned this Feb 3, 2024
@heifner heifner added the OCI Work exclusive to OCI team label Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heifner heifner

Labels
👍 lgtm OCI Work exclusive to OCI team
Projects
Team Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tests: Explicit shutdown since atexit not called on error AntelopeIO/leap
3 participants
@heifner @arhag @enf-ci-bot