Merge pull request #2192 from AntelopeIO/GH-2165-cluster-shutdown

Tests: Explicit shutdown since atexit not called on error
AntelopeIO · Feb 3, 2024 · 6fb3fe6 · 6fb3fe6
2 parents a131719 + de910b9
commit 6fb3fe6
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/tests/TestHarness/Cluster.py b/tests/TestHarness/Cluster.py
@@ -1,4 +1,3 @@
-import atexit
 import copy
 import subprocess
 import time
@@ -76,7 +75,6 @@ def __init__(self, localCluster=True, host="localhost", port=8888, walletHost="l
         keepRunning: [True|False] If true, leave nodes running when Cluster is destroyed. Implies keepLogs.
         keepLogs: [True|False] If true, retain log files after cluster shuts down.
         """
-        atexit.register(self.shutdown)
         self.accounts=[]
         self.nodes=[]
         self.unstartedNodes=[]

diff --git a/tests/TestHarness/TestHelper.py b/tests/TestHarness/TestHelper.py
@@ -184,3 +184,5 @@ def reportProductionAnalysis(thresholdMs):
         cluster.testFailed = not testSuccessful
         if walletMgr:
             walletMgr.testFailed = not testSuccessful
+
+        cluster.shutdown()
diff --git a/tests/trace_plugin_test.py b/tests/trace_plugin_test.py
@@ -117,6 +117,7 @@ def setUpClass(self):
     @classmethod
     def tearDownClass(self):
         TraceApiPluginTest.cluster.testFailed = not testSuccessful
+        TraceApiPluginTest.cluster.shutdown()
 
 if __name__ == "__main__":
     unittest.main()