Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: replay from before instant-finality transition #2141

Closed
Tracked by #2110
heifner opened this issue Jan 25, 2024 · 4 comments · Fixed by #2278 or #2287
Closed
Tracked by #2110

IF: replay from before instant-finality transition #2141

heifner opened this issue Jan 25, 2024 · 4 comments · Fixed by #2278 or #2287
Assignees
@heifner
Labels
👍 lgtm OCI Work exclusive to OCI team
Milestone
Leap v6.0.0-rc1

Comments

@heifner
Copy link
Member

heifner commented Jan 25, 2024 •
edited
Loading

When replaying: nodeos option --replay-blockchain we clear state database and replay all blocks including reversible blocks in the fork database. The fork database is opened and consumed before replay. This causes an issue as the fork database needed during replay (until instant-finality transition) requires the legacy fork database. After instant-finality transition, it requires the new fork database.

On replay, need to delay consuming the fork database until after all blocks are replayed so the fork database can be opened and consumed in the correct mode with the expected data (block_state_legacy vs block_state).

The following tests current fail and are commented waiting on completion of this task. They should be uncommented in tests/CMakeLists.txt and verify they work as part of this effort.

  • nodeos_irreversible_mode_if_lr_test
  • restart-scenarios-if-test-hard_replay
  • terminate-scenarios-if-test-replay
  • terminate-scenarios-if-test-hard_replay
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Jan 25, 2024
@arhag arhag mentioned this issue Jan 25, 2024
Closed
@heifner
Copy link
Member Author

heifner commented Jan 26, 2024

Immediate fix for hotstuff_integration branch. Update replay logic to not use fork_database::chain_head and instead pass current and previous to replay_push_block. replay_push_block can return the new pushed block state. Likely better to create a replay_push_irreversible_block (returns newly created block state) and replay_push_reveserable_block (just updates chain_head).

@heifner
Copy link
Member Author

heifner commented Jan 26, 2024

Long term fix: AntelopeIO/spring#7

heifner added a commit that referenced this issue Jan 26, 2024
@heifner
GH-1510 nodeos_irreversible_mode_if_lr_test requires GH-2141
37f0263
@arhag arhag added 👍 lgtm and removed triage labels Jan 29, 2024
@BenjaminGormanPMP BenjaminGormanPMP added this to the Leap v6.0.0-rc1 milestone Jan 30, 2024
heifner added a commit that referenced this issue Jan 30, 2024
@heifner
GH-1510 Add - restart-scenarios-if-test-resync
d980a43 
            - restart-scenarios-if-test-hard_replay (disabled) requires GH-2141
            - restart-scenarios-if-test-none
@heifner heifner mentioned this issue Jan 30, 2024
Merged
heifner added a commit that referenced this issue Jan 31, 2024
@heifner
GH-1510 Add - terminate-scenarios-if-test-resync
76fe85f 
            - terminate-scenarios-if-test-replay (disabled) requires #2141
            - terminate-scenarios-if-test-hard_replay
@greg7mdp
Copy link
Contributor

Uncomment test terminate-scenarios-if-test-hard_replay in tests/CMakeLists.txt when it works.

@greg7mdp greg7mdp mentioned this issue Feb 13, 2024
Merged
@heifner heifner mentioned this issue Feb 23, 2024
Closed
@heifner heifner self-assigned this Feb 26, 2024
@heifner heifner added the OCI Work exclusive to OCI team label Feb 26, 2024
@heifner heifner moved this from Todo to In Progress in Team Backlog Feb 26, 2024
@heifner heifner mentioned this issue Feb 27, 2024
Merged
heifner added a commit that referenced this issue Mar 4, 2024
@heifner
GH-2141 Move chain_head from fork database back to controller
de97670
@heifner heifner mentioned this issue Mar 4, 2024
Merged
@heifner heifner linked a pull request Mar 4, 2024 that will close this issue
IF: Refactor: Move chain_head from fork database back to controller #2278
Merged
heifner added a commit that referenced this issue Mar 4, 2024
@heifner
GH-2141 Rename apply_legacy and apply_savanna to apply_l and apply_s
1c7aa01
heifner added a commit that referenced this issue Mar 4, 2024
@heifner
Merge branch 'hotstuff_integration' into GH-2141-replay
fbc29cf
heifner added a commit that referenced this issue Mar 4, 2024
@heifner
Merge pull request #2278 from AntelopeIO/GH-2141-replay
df8de16 
IF: Refactor: Move chain_head from fork database back to controller
heifner added a commit that referenced this issue Mar 5, 2024
@heifner
GH-2141 Mainly refactoring. complete_block now holds a block_handle.
574ac4c 
Moved transition of block_state_legacy to block_state to controller out of fork_database.
Changed some fork_db.apply to chain_header apply where fork_db will not be available during replay.
@heifner heifner mentioned this issue Mar 6, 2024
Merged
heifner added a commit that referenced this issue Mar 6, 2024
@heifner
GH-2141 More descriptive error on block signed by unexpected key
ac673af
heifner added a commit that referenced this issue Mar 6, 2024
@heifner
GH-2141 Open fork database after replay of block log
09dcff4
heifner added a commit that referenced this issue Mar 6, 2024
@heifner
Merge remote-tracking branch 'origin/hotstuff_integration' into GH-2141…
07f3282 
…-replay
heifner added a commit that referenced this issue Mar 6, 2024
@heifner
GH-2141 Add include_root option to search_on_branch. Rename check_roo…
dc51cb8 
…t_t to include_root_t
heifner added a commit that referenced this issue Mar 6, 2024
@heifner
GH-2141 Add back replay tests
81388a5
@heifner heifner mentioned this issue Mar 6, 2024
Merged
@heifner heifner linked a pull request Mar 6, 2024 that will close this issue
IF: Support replay over instant finality transition #2287
Merged
heifner added a commit that referenced this issue Mar 7, 2024
@heifner
GH-2141 Fix log output
7169abc
heifner added a commit that referenced this issue Mar 7, 2024
@heifner
Merge pull request #2287 from AntelopeIO/GH-2141-replay
321aaa7 
IF: Support replay over instant finality transition
@heifner
Copy link
Member Author

heifner commented Mar 7, 2024

Resolved by #2287

@heifner heifner closed this as completed Mar 7, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Team Backlog Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heifner heifner

Labels
👍 lgtm OCI Work exclusive to OCI team
Projects
Team Backlog
Archived in project
Milestone
Leap v6.0.0-rc1
5 participants
@greg7mdp @heifner @arhag @enf-ci-bot @BenjaminGormanPMP