Comment out set_finalizer_test in api_tests.cpp.

The test can be re-enabled when #1911 is completed.
AntelopeIO · Dec 15, 2023 · 7db4760 · 7db4760
1 parent e85b0bf
commit 7db4760
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/libraries/chain/controller.cpp b/libraries/chain/controller.cpp
@@ -2317,8 +2317,9 @@ struct controller_impl {
       resource_limits.process_block_usage(bb.block_num());
 
 #if 0
-      bb.apply_dpos<void>([&](building_block::building_block_dpos& bb) {
-         auto proposed_fin_pol = pending->assembled_block_input.new_finalizer_policy();
+      // [greg todo] see https://github.com/AntelopeIO/leap/issues/1911
+      bb.apply_hs<void>([&](building_block::building_block_if& bb) {
+         auto proposed_fin_pol = bb.new_finalizer_policy;
          if (proposed_fin_pol) {
             // proposed_finalizer_policy can't be set until builtin_protocol_feature_t::instant_finality activated
             finalizer_policy fin_pol = std::move(*proposed_fin_pol);

diff --git a/unittests/api_tests.cpp b/unittests/api_tests.cpp
@@ -3856,6 +3856,9 @@ BOOST_AUTO_TEST_CASE(get_code_hash_tests) { try {
    check("test"_n, 3);
 } FC_LOG_AND_RETHROW() }
 
+#if 0
+// [greg todo]  re-implement the test after https://github.com/AntelopeIO/leap/issues/1911 is done
+
 // test set_finalizer host function serialization and tester set_finalizers
 BOOST_AUTO_TEST_CASE(set_finalizer_test) { try {
    validating_tester t;
@@ -3902,4 +3905,7 @@ BOOST_AUTO_TEST_CASE(set_finalizer_test) { try {
 
 } FC_LOG_AND_RETHROW() }
 
+#endif
+
+
 BOOST_AUTO_TEST_SUITE_END()