Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: hs_*_message types - review #1547

Closed
Tracked by #1508
heifner opened this issue Aug 23, 2023 · 2 comments · Fixed by #1560
Closed
Tracked by #1508

IF: hs_*_message types - review #1547

heifner opened this issue Aug 23, 2023 · 2 comments · Fixed by #1560
Assignees
@heifner
Labels
👍 lgtm OCI Work exclusive to OCI team

Comments

@heifner
Copy link
Member

heifner commented Aug 23, 2023 •
edited
Loading

Type for quorum_certificate.active_finalizers #1536 (comment)

This assumes 21 producers. Also since unsigned_int is used for value this has a upper limit of 32 finalizers (currently producers). Seems like quorum_certificate.active_finalizers should be a std::string instead to support greater than 32 finalizers. Note this affects on wire format so we need to get it right before 5.0.

Do we want to version hs_*_messages used by net_plugin. Note new ones can always be added by adding to net_message std::variant, but we might rather create a std::variant for each hs_*_message or add a uint16_t version as first element of each for internal versioning.
@heifner heifner mentioned this issue Aug 23, 2023
Closed
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Aug 23, 2023
@arhag arhag added 👍 lgtm and removed triage labels Aug 23, 2023
@heifner
Copy link
Member Author

heifner commented Aug 24, 2023

For now we will just add any new ones to the end of the net_message variant

@heifner heifner self-assigned this Aug 25, 2023
@heifner heifner added the OCI Work exclusive to OCI team label Aug 25, 2023
@heifner heifner moved this from Todo to In Progress in Team Backlog Aug 25, 2023
@heifner heifner added this to the Leap v5.0.0-rc1 milestone Aug 25, 2023
heifner added a commit that referenced this issue Aug 25, 2023
@heifner
GH-1547 Support unlimited finalizers
54129ed
@heifner heifner mentioned this issue Aug 25, 2023
Merged
@heifner heifner linked a pull request Aug 25, 2023 that will close this issue
IF: Support larger number of finalizers #1560
Merged
@heifner heifner moved this from In Progress to Awaiting Review in Team Backlog Aug 25, 2023
heifner added a commit that referenced this issue Aug 26, 2023
@heifner
GH-1547 Address peer review comments
2c8720e
heifner added a commit that referenced this issue Aug 26, 2023
@heifner
GH-1547 Create a seperate quorum_certificate_message type
dd9802a
heifner added a commit that referenced this issue Aug 26, 2023
@heifner
GH-1547 Minor cleanup
86c4305
heifner added a commit that referenced this issue Aug 28, 2023
@heifner
GH-1547 Use set instead of flip as this is indicating the specified f…
d588704 
…inalizer
heifner added a commit that referenced this issue Aug 28, 2023
@heifner
GH-1547 Use std::vector<unsigned_int> for quorum_certificate_message …
863033f 
…active_finalizers
heifner added a commit that referenced this issue Aug 28, 2023
@heifner
GH-1547 Minor cleanup
c2c0446
heifner added a commit that referenced this issue Aug 29, 2023
@heifner
Merge pull request #1560 from AntelopeIO/GH-1547-finalizer-set
4ef68bd 
IF: Support larger number of finalizers
@heifner
Copy link
Member Author

heifner commented Aug 29, 2023

Completed by #1560

@heifner heifner closed this as completed Aug 29, 2023
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog Aug 29, 2023
@arhag arhag removed this from the Leap v5.0.0-rc1 milestone Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heifner heifner

Labels
👍 lgtm OCI Work exclusive to OCI team
Projects
Team Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

IF: Support larger number of finalizers AntelopeIO/leap
3 participants
@heifner @arhag @enf-ci-bot