GH-1547 Address peer review comments

AntelopeIO · Aug 26, 2023 · 2c8720e · 2c8720e
1 parent 54129ed
commit 2c8720e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/libraries/chain/include/eosio/chain/hotstuff.hpp b/libraries/chain/include/eosio/chain/hotstuff.hpp
@@ -36,11 +36,11 @@ namespace eosio::chain {
          quorum_met = false;
       }
 
-      auto get_active_finalizers() const {
+      boost::dynamic_bitset<> get_active_finalizers() const {
          assert(!active_finalizers.empty());
          return boost::dynamic_bitset(active_finalizers);
       }
-      void set_active_finalizers(const auto& bs) {
+      void set_active_finalizers(const boost::dynamic_bitset<>& bs) {
          assert(!bs.empty());
          boost::to_string(bs, active_finalizers);
       }

diff --git a/libraries/hotstuff/qc_chain.cpp b/libraries/hotstuff/qc_chain.cpp
@@ -237,7 +237,7 @@ namespace eosio { namespace hotstuff {
       fc::crypto::blslib::bls_public_key agg_key;
 
       for (boost::dynamic_bitset<>::size_type i = 0; i < finalizers.size(); i++) {
-         if (finalizers[i] == 1){
+         if (finalizers[i]){
             //adding finalizer's key to the aggregate pub key
             if (first) {
                first = false;