Merge pull request #1649 from AntelopeIO/no_nullptr_memcpy_getactiondata

avoid possible memcpy with nullptr when action data size is 0
AntelopeIO · Sep 18, 2023 · 7be27dc · 7be27dc
2 parents cf0d9f4 + 0e1d5fa
commit 7be27dc
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/libraries/chain/webassembly/action.cpp b/libraries/chain/webassembly/action.cpp
@@ -5,9 +5,8 @@
 namespace eosio { namespace chain { namespace webassembly {
    int32_t interface::read_action_data(legacy_span<char> memory) const {
       auto s = context.get_action().data.size();
-      if( memory.size() == 0 ) return s;
-
       auto copy_size = std::min( static_cast<size_t>(memory.size()), s );
+      if( copy_size == 0 ) return s;
       std::memcpy( memory.data(), context.get_action().data.data(), copy_size );
 
       return copy_size;