GH-1916 fthreshold should be > to ensure Byzantine fault tolerance of…

… at least one
AntelopeIO · Nov 28, 2023 · 6ca044b · 6ca044b
1 parent be8ff28
commit 6ca044b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/libraries/chain/webassembly/privileged.cpp b/libraries/chain/webassembly/privileged.cpp
@@ -196,7 +196,7 @@ namespace eosio { namespace chain { namespace webassembly {
 
       // system contract should perform a duplicate check and fthreshold check before calling
       EOS_ASSERT( finalizers.size() == unique_finalizer_keys.size(), wasm_execution_error, "Duplicate finalizer bls key in finalizer set" );
-      EOS_ASSERT( finset.fthreshold >= f_weight_sum / 2, wasm_execution_error, "Finalizer set threshold cannot be met by finalizer weights" );
+      EOS_ASSERT( finset.fthreshold > f_weight_sum / 2, wasm_execution_error, "Finalizer set threshold cannot be met by finalizer weights" );
 
       context.control.set_proposed_finalizers( finset );
    }

diff --git a/libraries/testing/tester.cpp b/libraries/testing/tester.cpp
@@ -1186,7 +1186,7 @@ namespace eosio { namespace testing {
    }
 
    transaction_trace_ptr base_tester::set_finalizers(const vector<account_name>& finalizer_names) {
-      uint64_t fthreshold = finalizer_names.size() * 2 / 3;
+      uint64_t fthreshold = finalizer_names.size() * 2 / 3 + 1;
 
       fc::variants finalizer_auths;
       for (const auto& n: finalizer_names) {