Make action_receipt_digests_savanna as const& to parameter to block_s…

…tate_legacy
AntelopeIO · Apr 4, 2024 · 3465884 · 3465884
1 parent 486fed3
commit 3465884
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/libraries/chain/block_state_legacy.cpp b/libraries/chain/block_state_legacy.cpp
@@ -66,7 +66,7 @@ namespace eosio::chain {
    block_state_legacy::block_state_legacy( pending_block_header_state_legacy&& cur,
                                            signed_block_ptr&& b,
                                            deque<transaction_metadata_ptr>&& trx_metas,
-                                           std::optional<digests_t>&& action_receipt_digests_savanna,
+                                           const std::optional<digests_t>& action_receipt_digests_savanna,
                                            const protocol_feature_set& pfs,
                                            const validator_t& validator,
                                            const signer_callback_type& signer

diff --git a/libraries/chain/controller.cpp b/libraries/chain/controller.cpp
@@ -360,7 +360,7 @@ struct assembled_block {
       return std::visit(overloaded{[&](assembled_block_legacy& ab) {
                                       auto bsp = std::make_shared<block_state_legacy>(
                                          std::move(ab.pending_block_header_state), std::move(ab.unsigned_block),
-                                         std::move(ab.trx_metas), std::move(ab.action_receipt_digests_savanna), pfs, validator, signer);
+                                         std::move(ab.trx_metas), ab.action_receipt_digests_savanna, pfs, validator, signer);
                                       return completed_block{block_handle{std::move(bsp)}};
                                    },
                                    [&](assembled_block_if& ab) {

diff --git a/libraries/chain/include/eosio/chain/block_state_legacy.hpp b/libraries/chain/include/eosio/chain/block_state_legacy.hpp
@@ -27,7 +27,7 @@ namespace eosio::chain {
       block_state_legacy( pending_block_header_state_legacy&& cur,
                           signed_block_ptr&& b, // unsigned block
                           deque<transaction_metadata_ptr>&& trx_metas,
-                          std::optional<digests_t>&& action_receipt_digests_savanna,
+                          const std::optional<digests_t>& action_receipt_digests_savanna,
                           const protocol_feature_set& pfs,
                           const validator_t& validator,
                           const signer_callback_type& signer