check if public key string and signature string are invlid in conversion

AntelopeIO · Sep 7, 2023 · 2132734 · 2132734
1 parent e0a9901
commit 2132734
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/libraries/libfc/src/crypto/bls_public_key.cpp b/libraries/libfc/src/crypto/bls_public_key.cpp
@@ -15,7 +15,7 @@ namespace fc::crypto::blslib {
 
       std::array<uint8_t, 96> bytes = fc::crypto::blslib::deserialize_base64<std::array<uint8_t, 96>>(data_str);
 
-      constexpr bool check = false; // default
+      constexpr bool check = true; // check if base64str is invalid
       constexpr bool raw = true;
       std::optional<bls12_381::g1> g1 = bls12_381::g1::fromAffineBytesLE(bytes, check, raw);
       FC_ASSERT(g1);

diff --git a/libraries/libfc/src/crypto/bls_signature.cpp b/libraries/libfc/src/crypto/bls_signature.cpp
@@ -17,7 +17,7 @@ namespace fc::crypto::blslib {
 
          std::array<uint8_t, 192> bytes = fc::crypto::blslib::deserialize_base64<std::array<uint8_t, 192>>(data_str);
 
-         constexpr bool check = false; // default
+         constexpr bool check = true; // check if base64str is invalid
          constexpr bool raw = true;
          std::optional<bls12_381::g2> g2 = bls12_381::g2::fromAffineBytesLE(bytes, check, raw);
          FC_ASSERT(g2);