Add dynamic check for pagemap support #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is pagemap supported)
On WSL2: start/stop/start now works. |
heifner
approved these changes
Nov 13, 2023
| // Bit 62 page swapped | ||
| // Bit 63 page present | ||
| // | ||
| // Here we are just checking bit #55 (the soft-dirty bit). |
There was a problem hiding this comment.
I think we only need this comment once.
There was a problem hiding this comment.
Thanks, removed duplicate comment.
spoonincode
approved these changes
Nov 13, 2023
| fs::resize_file(path, pagesz); | ||
| bip::file_mapping mapping = bip::file_mapping(path.generic_string().c_str(), bip::read_write); | ||
| bip::mapped_region region = bip::mapped_region(mapping, bip::read_write); | ||
| char* p = (char *)region.get_address(); |
There was a problem hiding this comment.
I doubt you need to go through the trouble of creating a temporary file; you can probably just use a variable on the stack.
There was a problem hiding this comment.
You are right, that was way overkill, I simplified it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to better support systems like Ubuntu running under WSL2, where the kernel may be running without configured pagemap soft-dirty support, as shown by:
In this change, after attempting the clear the soft-dirty bits when opening a new chainbase db, we try mapping and modifying a 4K page to verify that the soft-dirty feature is working correctly.
@heifner could you try this branch on your system? I have some problems with my own WSL2/windows environment.