Handle signals, except SIGHUP, off the main thread #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg7mdp
approved these changes
Nov 1, 2024
|
Why is SIGHUP treated specially? |
Maintaining existing behavior. But that is a good question. We do want to have SIGHUP on the main thread because it calls the reload of logging.json on the main thread. But why hook it up during replay, no idea. |
|
It's weird... SIGHUP is treated like a shutdown during startup, but then like the config reload after startup 😞 |
spoonincode
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since signals are used to interrupt execution, handle them on a different thread so that they can interrupt the main thread execution if desired.