Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/centos build #971

Merged
merged 47 commits into from
Dec 11, 2024
Merged

Fix/centos build #971

merged 47 commits into from
Dec 11, 2024

Conversation

a-zakir
Copy link
Contributor

@a-zakir a-zakir commented Dec 6, 2024

No description provided.

Copy link
Member

@flomnes flomnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a few remarks

docker/centos7-build Outdated Show resolved Hide resolved
docker/centos7-build Show resolved Hide resolved
@flomnes
Copy link
Member

flomnes commented Dec 11, 2024

Also there seems to be an issue with PyQT5 being incompatible with python3.9 on Windows & Ubuntu, so you have to take care of this too

@a-zakir
Copy link
Contributor Author

a-zakir commented Dec 11, 2024

Also there seems to be an issue with PyQT5 being incompatible with python3.9 on Windows & Ubuntu, so you have to take care of this too

unrelated to this pr, in fact the centos build succeed

@a-zakir a-zakir merged commit a5ddfb2 into develop Dec 11, 2024
23 of 25 checks passed
@a-zakir a-zakir deleted the fix/centos-build branch December 11, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants