Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ant-2380] improving maintainability #965

Merged
merged 20 commits into from
Nov 26, 2024
Merged

Conversation

a-zakir
Copy link
Contributor

@a-zakir a-zakir commented Nov 12, 2024

This pull request includes several changes to the BendersBase class and related components to improve the handling of criterion computations and refactor the codebase. The most important changes include the renaming of OuterLoopInputData to CriterionInputData, the addition of the CouplingMapGenerator class, and the refactoring of methods related to criterion computations.

Refactoring and Renaming:

  • Renamed OuterLoopInputData to CriterionInputData and updated all related references in CriterionComputation.cpp and CriterionInputDataReader.cpp [1] [2] [3].
  • Removed the OuterloopOptionsFile method from BendersBase and updated the setCriterionsComputation method to setCriterionComputationInputs [1] [2] [3].

Addition of CouplingMapGenerator:

  • Added a new CouplingMapGenerator class to handle the building of input maps from structure files, encapsulating this functionality [1] [2].

Updates to Criterion Computation:

  • Refactored CriterionComputation to use CriterionInputData instead of OuterLoopInputData, updating methods and member variables accordingly [1] [2] [3].

CMakeLists and File Updates:

  • Updated CMakeLists.txt to reflect the renaming of files and the addition of new source files (CouplingMapGenerator.cpp) [1] [2].

Removal of Unused Methods:

  • Removed the build_input method from common.cpp as its functionality is now encapsulated in CouplingMapGenerator.

@a-zakir a-zakir merged commit 2715a1f into develop Nov 26, 2024
25 checks passed
@a-zakir a-zakir deleted the feature/improve-maintainability branch November 26, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants