-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ant-2380] improving maintainability #965
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbittar
requested changes
Nov 22, 2024
...pp/benders/benders_core/include/antares-xpansion/benders/benders_core/CriterionComputation.h
Show resolved
Hide resolved
...pp/benders/benders_core/include/antares-xpansion/benders/benders_core/CriterionComputation.h
Show resolved
Hide resolved
src/cpp/benders/benders_core/include/antares-xpansion/benders/benders_core/VariablesGroup.h
Outdated
Show resolved
Hide resolved
src/cpp/benders/benders_core/include/antares-xpansion/benders/benders_core/VariablesGroup.h
Outdated
Show resolved
Hide resolved
tbittar
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
BendersBase
class and related components to improve the handling of criterion computations and refactor the codebase. The most important changes include the renaming ofOuterLoopInputData
toCriterionInputData
, the addition of theCouplingMapGenerator
class, and the refactoring of methods related to criterion computations.Refactoring and Renaming:
OuterLoopInputData
toCriterionInputData
and updated all related references inCriterionComputation.cpp
andCriterionInputDataReader.cpp
[1] [2] [3].OuterloopOptionsFile
method fromBendersBase
and updated thesetCriterionsComputation
method tosetCriterionComputationInputs
[1] [2] [3].Addition of CouplingMapGenerator:
CouplingMapGenerator
class to handle the building of input maps from structure files, encapsulating this functionality [1] [2].Updates to Criterion Computation:
CriterionComputation
to useCriterionInputData
instead ofOuterLoopInputData
, updating methods and member variables accordingly [1] [2] [3].CMakeLists and File Updates:
CMakeLists.txt
to reflect the renaming of files and the addition of new source files (CouplingMapGenerator.cpp
) [1] [2].Removal of Unused Methods:
build_input
method fromcommon.cpp
as its functionality is now encapsulated inCouplingMapGenerator
.