Feature/detect_xpress_at_runtime #707

a-zakir · 2023-10-18T16:23:15Z

Detect Xpress at Runtime
Release one asset for each platform

JasonMarechal25 · 2023-10-31T14:02:55Z

I've tried to use it. When I run a simulation (example/SmallTestFiveCandidates) with solver = xpress but xpress missing from my env I get the following output

[Full Run - Problem Generation][INFO 31-10-2023 14:55:55] rename problems: false
Could not find the Xpress shared library. Looked in: [/lib/libxprs.so', '/opt/xpressmp/lib/libxprs.so', ']. Please check environment variable XPRESSDIR

Warning: false
Warning: false
Warning: false

With the warning repeated a lot of times
then

[Benders][INFO 31-10-2023 14:55:57] starting Benders mpi
                     LOG_LEVEL                                                 0
                MAX_ITERATIONS                                                -1
                  ABSOLUTE_GAP                                                10
                  RELATIVE_GAP                                             1e-06
                   RELAXED_GAP                                             1e-05
              SEPARATION_PARAM                                               0.5
            MASTER_FORMULATION                                           integer
                   AGGREGATION                                                 0
                    OUTPUTROOT                                                 .
                         TRACE                                                 1
                  SLAVE_WEIGHT                                          CONSTANT
            SLAVE_WEIGHT_VALUE                                                 3
                   MASTER_NAME                                            master
                STRUCTURE_FILE                                     structure.txt
                     INPUTROOT                                                 .
                      CSV_NAME                              benders_output_trace
                   BOUND_ALPHA                                                 1
                   SOLVER_NAME                                            XPRESS
                     JSON_FILE/home/marechaljas/CLionProjects/antares-xpansion/examples/SmallTestFiveCandidates/output/20231031-1455eco-Xpansion/expansion/out.json
      LAST_ITERATION_JSON_FILE/home/marechaljas/CLionProjects/antares-xpansion/examples/SmallTestFiveCandidates/output/20231031-1455eco-Xpansion/expansion/last_iteration.json
                    TIME_LIMIT                                             1e+12
               LAST_MASTER_MPS                             master_last_iteration
                        RESUME                                                 0
             LAST_MASTER_BASIS                             master_last_basis.bss
                    BATCH_SIZE                                                 0



Warning: false
[Benders][INFO 31-10-2023 14:55:57] error: This is line 93 of file /home/marechaljas/CLionProjects/antares-xpansion/src/cpp/multisolver_interface/SolverFactory.cpp (function create_solver)
Solver 'XPRESS' not supported

--------------------------------------------------------------------------
MPI_ABORT was invoked on rank 0 in communicator MPI_COMM_WORLD
with errorcode 1.

If I run with default solver it works as intended. However I do get:

Could not find the Xpress shared library. Looked in: [/lib/libxprs.so', '/opt/xpressmp/lib/libxprs.so', ']. Please check environment variable XPRESSDIR

Warning: false

With the last warning repeated several times

I note 3 points:

The "Warning false" obscuring the output
The warning around xpress when we didn't ask for an xpress simulation
The error at benders step when Xpress is not present. This should be caught earlier

flomnes · 2023-11-10T12:31:00Z

src/cpp/multisolver_interface/environment.cc

+  xpress_dynamic_library->GetFunction(&XPRSinit, "XPRSinit");
+  xpress_dynamic_library->GetFunction(&XPRScopyprob, "XPRScopyprob");
+  xpress_dynamic_library->GetFunction(&XPRSwritebasis, "XPRSwritebasis");
+  xpress_dynamic_library->GetFunction(&XPRSreadprob, "XPRSreadprob");
+  xpress_dynamic_library->GetFunction(&XPRSreadbasis, "XPRSreadbasis");
+  xpress_dynamic_library->GetFunction(&XPRSgetrows, "XPRSgetrows");
+  xpress_dynamic_library->GetFunction(&XPRSgetindex, "XPRSgetindex");
+  xpress_dynamic_library->GetFunction(&XPRSgetnames, "XPRSgetnames");


You can keep here only the XPRS functions that are actually called. See for example grep XPRS

I commented out the unnecessary functions and added others especially for xpansion. I have to do it also with defines.
this needs to be cleaned

src/cpp/multisolver_interface/environment.cc

flomnes · 2023-11-10T12:35:00Z

src/cpp/multisolver_interface/CMakeLists.txt

@@ -68,5 +73,6 @@ if(COIN_OR)
 			Coin::CoinUtils
 			Coin::Osi
 			Coin::Cbc
+		   ${CMAKE_DL_LIBS}


I recommend creating a library to load XPRESS, and to link it against -ldl

Also, -ldl doesn't exist in Windows

src/cpp/multisolver_interface/SolverXpress.cpp

src/cpp/multisolver_interface/CMakeLists.txt

Co-authored-by: Florian Omnès <[email protected]>

JasonMarechal25 · 2023-11-16T14:34:52Z

src/cpp/multisolver_interface/SolverFactory.cpp

 #ifdef COIN_OR
 #include "SolverCbc.h"
 #include "SolverClp.h"
 #endif
 #include "LogUtils.h"
 #include "multisolver_interface/SolverFactory.h"
+std::vector<std::string> tmp;


Can you give a more meaningful name to this variable please?

sonarqubecloud · 2023-11-16T17:14:27Z

SonarCloud Quality Gate failed.

2 Bugs
0 Vulnerabilities
0 Security Hotspots
116 Code Smells

20.6% Coverage
0.0% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

a-zakir added 2 commits October 18, 2023 09:15

start

3519bf7

start

1cd9fa2

pull-request-size bot added the size/XL label Oct 18, 2023

JasonMarechal25 linked an issue Oct 19, 2023 that may be closed by this pull request

Load xpress at runtime #698

Closed

add more function

d9f7126

pull-request-size bot added size/XXL and removed size/XL labels Oct 19, 2023

a-zakir added 23 commits October 19, 2023 02:45

by default add Xpress in available solvers list

3963904

Merge branch 'develop'

1b7746c

it works!

45f1a0b

it works 2

2e0b58f

tidy

57461f6

unload unused function

1c88437

fix conversion path->string

de57ad5

add newline after msf

0450e4c

set xpress dir env var

2393fdd

windows set env var XPRESSDIR

88ba8c7

update windows getenv method

d784054

update getenv

ca3b226

write err in stderr

5b8710c

build clean path

239c78f

print clearer err message

f46956a

list xpress dir

d30bdf3

list xpress dir 2

ea1c4f0

list xpress dir 3

fbd3fda

list xpress dir 4

80a7815

list xpress dir 5

65f0ec1

remove prepos

ccbdf13

some move

682bd83

move header file

925a4a7

a-zakir added 3 commits October 24, 2023 12:28

treat warning

9aa3c50

remove prints

b5d1f37

do right

d5c55f7

a-zakir requested a review from flomnes November 10, 2023 09:12

flomnes reviewed Nov 10, 2023

View reviewed changes

a-zakir and others added 10 commits November 10, 2023 14:53

suggestion by @flomnes

0c9c969

Co-authored-by: Florian Omnès <[email protected]>

suggestion by @flomnes

daa0971

Co-authored-by: Florian Omnès <[email protected]>

suggestion by @florian

06ed31a

rename namespace

9da5a5a

remove commented code

2ce15ba

resolve conflicts

562aa15

init Xpress env if needed

5731bce

check available Solvers once per program

dd28db3

set Xpress bool check

6340cb2

print the right log messages

fa6cbf6

JasonMarechal25 requested changes Nov 16, 2023

View reviewed changes

rename compile unit variable

6aa147d

a-zakir closed this Nov 24, 2023

watermelon-copilot-for-code-review bot mentioned this pull request Dec 11, 2023

Feature/detect xpress at runtime #724

Merged

watermelon-copilot-for-code-review bot mentioned this pull request Dec 20, 2023

print low level logs #719

Merged

a-zakir deleted the feature/detect_xpress_at_runtime branch October 9, 2024 12:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/detect_xpress_at_runtime #707

Feature/detect_xpress_at_runtime #707

a-zakir commented Oct 18, 2023 •

edited by JasonMarechal25

Loading

JasonMarechal25 commented Oct 31, 2023 •

edited

Loading

flomnes Nov 10, 2023

a-zakir Nov 10, 2023

flomnes Nov 10, 2023

JasonMarechal25 Nov 16, 2023

a-zakir Nov 16, 2023

sonarqubecloud bot commented Nov 16, 2023

Feature/detect_xpress_at_runtime #707

Feature/detect_xpress_at_runtime #707

Conversation

a-zakir commented Oct 18, 2023 • edited by JasonMarechal25 Loading

JasonMarechal25 commented Oct 31, 2023 • edited Loading

flomnes Nov 10, 2023

Choose a reason for hiding this comment

a-zakir Nov 10, 2023

Choose a reason for hiding this comment

flomnes Nov 10, 2023

Choose a reason for hiding this comment

JasonMarechal25 Nov 16, 2023

Choose a reason for hiding this comment

a-zakir Nov 16, 2023

Choose a reason for hiding this comment

sonarqubecloud bot commented Nov 16, 2023

a-zakir commented Oct 18, 2023 •

edited by JasonMarechal25

Loading

JasonMarechal25 commented Oct 31, 2023 •

edited

Loading