Ci/centos #696
Merged
Ci/centos #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JasonMarechal25
commented
Oct 10, 2023
•
JasonMarechal25
commented
- Remove "CentOS" dockerfile
- Rename "CentOS-bare" dockerfile as "CentOS-system-deps"
- "CentOS-system-deps" dockefile provide just the system configuration to build on centOS. No third party dependency (boost, tbb, etc)
- Update ublish-Docker-Github-Action to use main branch instead of master branch
- CentOS build-system-deps action now use "CentOS-system-deps" container
a-zakir
reviewed
Oct 13, 2023
tbittar
approved these changes
Oct 17, 2023
a-zakir
reviewed
Oct 17, 2023
| - name: Install dependencies | ||
| run: | | ||
| pip3 install --upgrade pip | ||
| pip3 install wheel #Does not work in requirements |
There was a problem hiding this comment.
is wheel a new dependency? why ?
a-zakir
reviewed
Oct 17, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.