Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inconsistency with cpp impl #3

Merged
merged 6 commits into from
Jul 28, 2024
Merged

Fix inconsistency with cpp impl #3

merged 6 commits into from
Jul 28, 2024

Conversation

sylvlecl
Copy link
Member

This PR aims at:

  1. fixing differences we have identified with the c++ implementation of the TS generation
  2. improve a little the design by isolating more the RNG part

@sylvlecl
Bix behaviour compared to c++ impl, improve design
e9e0e74 
 - fix: RNG is skipped when volatility is 0
 - RNG as an argument to higher level generators

Signed-off-by: Sylvain Leclerc <[email protected]>
@sylvlecl sylvlecl force-pushed the fix-inconsistency-with-cpp-impl branch from 30ea8db to e9e0e74 Compare July 27, 2024 10:44
@sylvlecl sylvlecl marked this pull request as ready for review July 28, 2024 12:36
@sylvlecl sylvlecl merged commit dcc8da0 into main Jul 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sylvlecl