Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(upgrade): add v9.2 upgrader #20

Merged
merged 5 commits into from
Oct 15, 2024
Merged

Conversation

MartinBelthle
Copy link
Contributor

No description provided.

@MartinBelthle MartinBelthle requested a review from flomnes October 14, 2024 14:26
Copy link
Member

@flomnes flomnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make a function for links, one for ST storages, etc.

src/antares/study/version/upgrade_app/upgrader_0902.py Outdated Show resolved Hide resolved
src/antares/study/version/upgrade_app/upgrader_0902.py Outdated Show resolved Hide resolved
src/antares/study/version/upgrade_app/upgrader_0902.py Outdated Show resolved Hide resolved
@MartinBelthle MartinBelthle requested a review from flomnes October 15, 2024 08:23
flomnes
flomnes previously approved these changes Oct 15, 2024
variables_selection = data["variables selection"]
possible_variables = _get_possible_variables()
d: t.Dict[str, t.Dict[str, t.List[str]]] = {}
for sign in ["+", "-"]:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add comments here to explain what d["select_var +"]["remove"] mean, etc.

src/antares/study/version/upgrade_app/upgrader_0902.py Outdated Show resolved Hide resolved
@MartinBelthle MartinBelthle merged commit 2cde4e1 into main Oct 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants