Skip to content

Commit

Permalink
PR remarks
Browse files Browse the repository at this point in the history
  • Loading branch information
flomnes committed Aug 20, 2024
1 parent 73a158e commit e1fc725
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions tests/create_app/test_create_app.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,6 @@ def test_create_app(self, tmp_path: Path, study_version: StudyVersion):
"version": expected_version,
}

created_date = datetime.datetime.fromtimestamp(int(properties["created"]))
last_save_date = datetime.datetime.fromtimestamp(int(properties["lastsave"]))
created_date = datetime.datetime.fromtimestamp(ini_reader.getint("antares", "created"))
last_save_date = datetime.datetime.fromtimestamp(ini_reader.getint("antares", "lastsave"))
assert last_save_date == created_date
4 changes: 2 additions & 2 deletions tests/upgrade_app/test_upgrade_0900.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
# from antares.study.version.upgrade_app.upgrader_0900 import UpgradeTo0900
from antares.study.version.upgrade_app import UpgradeApp
from antares.study.version import StudyVersion
from antares.study.version.ini_reader import IniReader
from tests.conftest import StudyAssets

from tests.helpers import are_same_dir, DEFAULT_IGNORES

def get_version(d): # type: ignore
"""
Expand All @@ -29,3 +28,4 @@ def test_nominal_case(study_assets: StudyAssets):
# We can't check the entire files because of attribute
# antares.lastsave
assert get_version(actual) == get_version(expected)
assert are_same_dir(study_assets.study_dir, study_assets.expected_dir, ignore = DEFAULT_IGNORES | {"study.antares"})

0 comments on commit e1fc725

Please sign in to comment.