Modeler 4.6: system import [ANT-2207] #2530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
payetvin
force-pushed
the
feature/4.6-system-import
branch
from
4d4820f to
963cbea
Compare
flomnes
reviewed
Dec 17, 2024
| } | ||
| }; | ||
|
|
||
| static std::pair<std::string, std::string> splitLibraryModelString(const std::string& s) |
There was a problem hiding this comment.
Use a dedicated struct for the return type
There was a problem hiding this comment.
I think it's fine to use a pair and get var like this in this context const auto [libraryId, modelId] = getSplit...
|
flomnes
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add the ability to read a YAML file containing all the infos about the electric system and which models they're related to, converting it into system-model structures.