Remove dynamic manually allocated memory #2273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 065acfb.
flomnes
reviewed
Jul 22, 2024
There was a problem hiding this comment.
Correlation::retrieveMontlyMatrixArray is unused, consider removing it. It would be a good thing since std::unique_ptr::get is "dangerous", it can easily lead to dangling pointers
auto ptr = std::make_unique<Cow>();
Cow* cow = ptr.get();
// ptr goes out of scope, is deleted
cow->moo(); // segfault
flomnes
approved these changes
Jul 22, 2024
We create a shared_ptr on the stack, stock the raw pointer in a vector then exit the scop. At this point the pointer is not valid anymore
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.