Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix infeasible analyzer #2222

Closed
wants to merge 2 commits into from
Closed

Fix infeasible analyzer #2222

wants to merge 2 commits into from

Conversation

guilpier-code
Copy link
Contributor

@guilpier-code guilpier-code commented Jul 2, 2024 •
edited
Loading

This PR is attached to ticket ticket ANT-1825.
Some improvements were made or tried by taking care of the ticket.
The result is this PR.

What was done :

  • hydro scope :
    • move the code that prints the TS numbers on disk : due to recent changes it was moved after the loop through MC years. So, we have to wait until simulation ends to know which TS numbers where drawn. So we move that code back.
  • infeasibility analyzer scope
    • Constraint :: extractItems() was simplified
    • Some renaming, meant to be more expressive
    • Add a type of constraint to be spotted by the analyzer in case of infeasibility
    • what else ?

@guilpier-code guilpier-code requested review from sylvlecl and flomnes July 2, 2024 12:01
@guilpier-code guilpier-code marked this pull request as draft July 2, 2024 12:23
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jul 2, 2024
flomnes
flomnes requested changes Jul 2, 2024
View reviewed changes
Copy link
Member

@flomnes flomnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. However, could you please split this into 3 PRs ?

  • (A) Renaming
  • (B) Use boost::algorithm::split_regex
  • (C) Move the write of ts-numbers

A possibility is

(develop) <----- C
          \-----  A <----- B

But at your convenience.

@guilpier-code
Copy link
Contributor Author

Was divided into 4 pull requests :

@guilpier-code guilpier-code deleted the fix/infeasible-analyzer branch July 3, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flomnes flomnes flomnes requested changes

@sylvlecl sylvlecl Awaiting requested review from sylvlecl

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guilpier-code @flomnes