Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check formatting as part of the CI #2193

Merged
merged 9 commits into from
Jun 26, 2024
Merged

Check formatting as part of the CI #2193

merged 9 commits into from
Jun 26, 2024

Conversation

flomnes
Copy link
Member

@flomnes flomnes commented Jun 25, 2024

Succeed if all source files are well formated. Fail otherwise, and display ill-formatted files.

@flomnes flomnes requested a review from a-zakir June 25, 2024 12:55
@flomnes flomnes changed the title clang-format in CI Check formatting as part of the CI Jun 25, 2024
DIFF=`git status --porcelain`
if [[ $DIFF ]]; then
echo "The following files are not well formatted"
echo "$DIFF"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

upload diff file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to dl & apply the patch ;)

@a-zakir
Copy link
Contributor

a-zakir commented Jun 25, 2024

i'll consider formatting changed files only

@a-zakir
Copy link
Contributor

a-zakir commented Jun 25, 2024

i'll consider formatting changed files only
this Pr is definitely an enhancement

@flomnes flomnes requested a review from a-zakir June 25, 2024 13:45
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@a-zakir a-zakir merged commit 3ca9107 into develop Jun 26, 2024
7 of 8 checks passed
@a-zakir a-zakir deleted the fix/clang-format-ci branch June 26, 2024 09:19
a-zakir added a commit that referenced this pull request Jun 26, 2024
a-zakir added a commit that referenced this pull request Jun 26, 2024
@a-zakir a-zakir restored the fix/clang-format-ci branch June 26, 2024 09:25
@a-zakir a-zakir mentioned this pull request Jun 26, 2024
@a-zakir a-zakir deleted the fix/clang-format-ci branch September 4, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants