Move data validation to specialized functions [ANT-1213] #2149
Conversation
| @@ -95,8 +95,9 @@ class PreproHydro | |||
| ** \param folder The source folder (ex: `input/hydro/prepro`) | |||
| ** \return A non-zero value if the operation succeeded, 0 otherwise | |||
| */ | |||
| bool loadFromFolder(Study& s, const AreaName& areaID, const char folder[]); | |||
| bool loadFromFolder(Study& s, const AreaName& areaID, const std::string& folder); | |||
There was a problem hiding this comment.
Is it possible (or usefull) to use std::filesystem::path for folder ?
There was a problem hiding this comment.
will be done in another PR
| if (col[day] < 0. || (i % 2U /*column hours*/ && col[day] > 24.)) | ||
| { | ||
| logs.error() << areaName << ": invalid power or energy value"; | ||
| return false; |
There was a problem hiding this comment.
Carefull
With the early return you are returning after the first error. Previous behaviour is to check all values and log all errors.
There was a problem hiding this comment.
if (!errorPower avoided going into this scope after the first error, I simplified while keeping the same behavior
There was a problem hiding this comment.
No you don't keep the same behavior. The user will only see the 1st error, not the following ones if any.
Co-authored-by: Vincent Payet <[email protected]> Co-authored-by: payetvin <[email protected]>
|
Please retry analysis of this Pull-Request directly on SonarCloud |
| if (col[day] < 0. || (i % 2U /*column hours*/ && col[day] > 24.)) | ||
| { | ||
| logs.error() << areaName << ": invalid power or energy value"; | ||
| return false; |
There was a problem hiding this comment.
No you don't keep the same behavior. The user will only see the 1st error, not the following ones if any.
…esSimulatorTeam/Antares_Simulator into feature/modular-validation
|
flomnes
dismissed
JasonMarechal25’s stale review
I checked, behavior is unchanged
The goal of this PR is to separate loading and validation of data.
This separation will allow to have a modular loading.