Remove hydro hotstart [ANT-1815] #2131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilpier-code
requested changes
Jun 3, 2024
| @@ -167,10 +167,9 @@ class PartHydro | |||
| // As this function can be called a lot of times, we pass working variables and returned variables | |||
| // as arguments, so that we don't have to create them locally (as in a classical function) each | |||
| // time. | |||
| void getWaterValue(const double& level, | |||
| double getWaterValue(const double& level, | |||
There was a problem hiding this comment.
Took advantage of the hydro hot start removal to make some quick and small cleanings.
guilpier-code
previously approved these changes
Jun 3, 2024
a-zakir
reviewed
Jun 4, 2024
| @@ -587,20 +587,6 @@ _**This section is under construction**_ | |||
| ## Other parameters | |||
| These parameters are listed under the `[other preferences]` section in the `.ini` file. | |||
|
|
|||
| --- | |||
There was a problem hiding this comment.
i think we have to write somewhere that this option is deprecated
a-zakir
reviewed
Jun 4, 2024
a-zakir
reviewed
Jun 4, 2024
| @@ -156,14 +156,12 @@ AdvancedParameters::AdvancedParameters(wxWindow* parent) : | |||
| // Initial reservoir levels | |||
| { | |||
| label = Component::CreateLabel(this, wxT("Initial reservoir levels")); | |||
| button = new Component::Button(this, wxT("cold start"), "images/16x16/tag.png"); | |||
| button = new Component::Button(this, wxT(""), "images/16x16/tag.png"); | |||
There was a problem hiding this comment.
Because we should leave a trace that this functionality (hydro hot start) used to exist but no longer does (deprecation).
flomnes
reviewed
Jun 6, 2024
flomnes
reviewed
Jun 11, 2024
src/solver/simulation/include/antares/solver/simulation/solver.hxx
Outdated
Show resolved
Hide resolved
flomnes
approved these changes
Jun 17, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AntaresSimulatorTeam/Antares_Simulator_Tests_NR#24
Previously, the default value for property
initial-reservoir-levelswascold start.