-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parallel years cleaning : few removal of "numspace" #2128
Conversation
@@ -113,65 +113,6 @@ static void RecalculDesEchangesMoyens(Data::Study& study, | |||
} | |||
} | |||
|
|||
void PrepareDataFromClustersInMustrunMode(Data::Study& study, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function (PrepareDataFromClustersInMustrunMode) has many drawbacks :
- It's too long
- It's supposed to offer a treatment common to mode adequacy and economy but its body clearly separates adequacy mode and the other modes (economy)
- it's complicated : for example, we have 2 loops over thermal clusters of an area, though we could only have one.
So we removed this function from common-eco-adq.cpp and put down these calculations in specialized functions associated to each simulation mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #2168
…ed value and check its value right after ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the awesome work @guilpier-code ! Can you split this PR in 2 ? The double count issue for adequacy needs a bit more investigation
…stRunMode" This reverts commit 50d2e06.
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Spin-off from #2128 Credits @guilpier-code --------- Co-authored-by: Vincent Payet <[email protected]> Co-authored-by: payetvin <[email protected]>
See ticket #1751
For now, just a first analyze of how we could do to isolate years (from the simulation and what should not be inside a year).
We take advantage of this to make some removals of numSpace.
Comments :
For instance, when running a year of simulation, we call a function of the simulation object, not of the year object.
Goals :
We want to isolate year jobs to make cleaner parallelism.
Each year job should be designed so that it can be run in a thread independently from any other year job.
In particular, a year job should hold its own memory spaces, and not shared memory as done currently.