-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3rd try at scenario building #2033
base: poc_linearProblem
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need to keep testing that the new fillers are compatible with the legacy problem. instead of deleting this, you can replace the new fillers it uses with the ones use in "new-workflow/standard-test"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I tried but ran into the following issue : ports are not implemented for LegacyLinearProblem
/LegacyLinearProblemFillerImpl
. So it's a bit hard to connect battery / thermal to legacy balance constraints. This is not related to scenarization, so I'll open another PR for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when using the ComponentFiller of "BALANCE" type, the used AddBalanceConstraint in it will hook the new balance terms to the legacy constraint (meaning you don't need a port, it is implicit). you only have to make sure the ComponentFiller has the same node name as the legacy node
const std::map<std::string, std::vector<double>>& scalarData, | ||
const std::map<std::string, std::vector<std::vector<double>>>& timedData) : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const std::map<std::string, std::vector<double>>& scalarData, | |
const std::map<std::string, std::vector<std::vector<double>>>& timedData) : | |
const std::map<std::string, std::vector<double>>& scalarDataPerScenario, | |
const std::map<std::string, std::vector<std::vector<double>>>& timedDataPerScenario) : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be interesting to add a new test, inspired by the ones here, to test multiple scenarios
double getObjectiveValue() | ||
{ | ||
return objectiveValue_; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
objectiveValue_
is set at construction. I think it should be extracted after Solve
. But then we have to manage a cache with synchronization issues, etc. So I suggest not caching the objective value for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MipSolution is constructed after Solve
39d9f3b
to
08bc95c
Compare
src/.clang-format
TODO