Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

De-templatize HydroManagement::prepareNetDemand #1679

Merged
merged 2 commits into from
Oct 5, 2023
Merged

De-templatize HydroManagement::prepareNetDemand #1679

merged 2 commits into from
Oct 5, 2023

Conversation

flomnes
Copy link
Member

@flomnes flomnes commented Oct 5, 2023

Templates make for larger binaries since 2 functions are required.

@flomnes
De-templatize HydroManagement::prepareNetDemand
5d55e3e 
Templates make for larger binaries since 2 functions are required.
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@flomnes flomnes requested a review from guilpier-code October 5, 2023 13:11
@flomnes flomnes merged commit 1b89fbf into develop Oct 5, 2023
8 checks passed
@flomnes flomnes deleted the fix/de-templatize-net-demand branch October 5, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guilpier-code guilpier-code guilpier-code approved these changes

Assignees
No one assigned
Labels
cleaning code quality size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flomnes @guilpier-code