Remove manual alloc and update code standards in hydro/daily2 #1651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flomnes
reviewed
Sep 28, 2023
src/solver/hydro/daily2/h2o2_j_resoudre_le_probleme_lineaire.cpp
Outdated
Show resolved
Hide resolved
src/solver/hydro/daily2/h2o2_j_resoudre_le_probleme_lineaire.cpp
Outdated
Show resolved
Hide resolved
flomnes
reviewed
Sep 28, 2023
|
Kudos, SonarCloud Quality Gate passed! |
a-zakir
approved these changes
Oct 3, 2023
| @@ -115,8 +127,7 @@ typedef struct | |||
| PROBLEME_LINEAIRE_PARTIE_FIXE ProblemeLineairePartieFixe; | |||
There was a problem hiding this comment.
@payetvin there is another definition for PROBLEME_HYDRAULIQUE PROBLEME_LINEAIRE_PARTIE_FIXE in h2o_j_donn
flomnes
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1575