[DEV] code smells

AntaresSimulatorTeam · Oct 19, 2023 · f18ca5e · f18ca5e
1 parent 2b3a3e9
commit f18ca5e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/src/libs/antares/study/parts/series/include/antares/series/series.h b/src/libs/antares/study/parts/series/include/antares/series/series.h
@@ -38,7 +38,7 @@ class TimeSeries
     using TSNumbers = Matrix<uint32_t>;
     using TS = Matrix<double>;
 
-    TimeSeries(TSNumbers& tsNumbers);
+    explicit TimeSeries(TSNumbers& tsNumbers);
     /*!
      ** \brief Load series from a file
      **

diff --git a/src/solver/hydro/management/management.cpp b/src/solver/hydro/management/management.cpp
@@ -261,7 +261,7 @@ bool HydroManagement::checkYearlyMinGeneration(uint numSpace, uint year, const D
     return true;
 }
 
-bool HydroManagement::checkWeeklyMinGeneration(uint year, Data::Area& area) const
+bool HydroManagement::checkWeeklyMinGeneration(uint year, const Data::Area& area) const
 {
     auto const& srcinflows =  area.hydro.series->storage.getColumn(year);
     auto const& srcmingen = area.hydro.series->mingen.getColumn(year);
@@ -295,7 +295,7 @@ bool HydroManagement::checkWeeklyMinGeneration(uint year, Data::Area& area) cons
     return true;
 }
 
-bool HydroManagement::checkHourlyMinGeneration(uint year, Data::Area& area) const
+bool HydroManagement::checkHourlyMinGeneration(uint year, const Data::Area& area) const
 {
     // Hourly minimum generation <= hourly inflows for each hour
     auto const& srcmingen = area.hydro.series->mingen.getColumn(year);

diff --git a/src/solver/hydro/management/management.h b/src/solver/hydro/management/management.h
@@ -129,9 +129,9 @@ class HydroManagement final
     //! check Yearly minimum generation is lower than available inflows
     bool checkYearlyMinGeneration(uint numSpace, uint tsIndex, const Data::Area& area) const;
     //! check Weekly minimum generation is lower than available inflows
-    bool checkWeeklyMinGeneration(uint tsIndex, Data::Area& area) const;
+    bool checkWeeklyMinGeneration(uint tsIndex, const Data::Area& area) const;
     //! check Hourly minimum generation is lower than available inflows
-    bool checkHourlyMinGeneration(uint tsIndex, Data::Area& area) const;
+    bool checkHourlyMinGeneration(uint tsIndex, const Data::Area& area) const;
     //! check minimum generation is lower than available inflows
     bool checkMinGeneration(uint numSpace, uint year) const;
     //! Prepare the net demand for each area