Fix find cluster logic (#2537)

AntaresSimulatorTeam · Dec 17, 2024 · 938d726 · 938d726
1 parent bf05c8f
commit 938d726
Showing 1 changed file with 12 additions and 13 deletions.
diff --git a/src/libs/antares/study/parts/short-term-storage/container.cpp b/src/libs/antares/study/parts/short-term-storage/container.cpp
@@ -133,20 +133,19 @@ bool STStorageInput::LoadConstraintsFromIniFile(const fs::path& parent_path)
             return false;
         }
 
-        // TODO not the fastest way
-        for (auto& cluster: storagesByIndex)
+        auto it = std::find_if(storagesByIndex.begin(),
+                               storagesByIndex.end(),
+                               [&constraint](const STStorageCluster& cluster)
+                               {return cluster.id == constraint.cluster_id; });
+        if (it == storagesByIndex.end())
         {
-            if (cluster.id == constraint.cluster_id)
-            {
-                cluster.additional_constraints.push_back(constraint);
-            }
-            else
-            {
-                logs.warning() << " from file " << pathIni;
-                logs.warning() << "Constraint " << section->name
-                               << "does not reference an existing cluster (" << cluster.id
-                               << "),\n therefore it is ignored!";
-            }
+            logs.warning() << " from file " << pathIni;
+            logs.warning() << "Constraint " << section->name
+                           << " does not reference an existing cluster";
+        }
+        else
+        {
+            it->additional_constraints.push_back(constraint);
         }
     }