New log msg when solver not found in or-tools (#1687)

* New log msg when solver not found in or-tools * New log msg when solver not found in or-tools : oops, correct an oblivion
AntaresSimulatorTeam · Oct 6, 2023 · 3b8c7b7 · 3b8c7b7
1 parent 8c362df
commit 3b8c7b7
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/src/solver/utils/ortools_utils.cpp b/src/solver/utils/ortools_utils.cpp
@@ -364,11 +364,16 @@ MPSolver* MPSolverFactory(const Antares::Optimization::PROBLEME_SIMPLEXE_NOMME*
             solver = MPSolver::CreateSolver((OrtoolsUtils::solverMap.at(solverName)).LPSolverName);
 
         if (!solver)
-            throw Antares::Data::AssertionError("Solver not found: " + solverName);
+        {
+            std::string msg_to_throw = "Solver " + solverName + " not found. \n";
+            msg_to_throw += "Please make sure that your OR-Tools install supports solver " + solverName + ".";
+
+            throw Antares::Data::AssertionError(msg_to_throw);
+        }
     }
     catch (...)
     {
-        Antares::logs.error() << "Solver creation failed";
+        Antares::logs.error() << "Solver creation failed.";
         throw;
     }
 

diff --git a/src/tests/run-study-tests/test_unfeasible_problem.py b/src/tests/run-study-tests/test_unfeasible_problem.py
@@ -64,5 +64,4 @@ def test_unfeasible_problem_01__warning_dry(study_path, check_runner):
     checks.add(check = unfeasible_problem(study_path, new_behavior="warning-dry",
                                           checks_on_weeks=warnings_on_weeks,
                                           simulation=check_runner.get_simulation()))
-    check_runner.run(checks)
-
+    check_runner.run(checks)