fix(list_dir): check permissions and consider workspace filters config #2279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smailio
reviewed
Jan 3, 2025
| child.is_dir() | ||
| and not is_study_folder(child) | ||
| and not should_ignore_folder_for_scan(child) | ||
| and not child.name.startswith((".", "$")) |
There was a problem hiding this comment.
the name check for hidden file doesn't work on windows, does it?
There was a problem hiding this comment.
I removed this code to use the workspace filters to mutualize the code
MartinBelthle
changed the title
.* and $* folders
smailio
reviewed
Jan 9, 2025
antarest/study/storage/utils.py
Outdated
| return False | ||
| return not ( | ||
| path.is_dir() | ||
| and any([re.search(regex, path.name) for regex in filter_in]) |
There was a problem hiding this comment.
do you need to use a list here instead of just the generator ? like this any(re.search(regex, path.name) for regex in filter_in)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will fix back-end issues inside [ANT-615]