fix(tasks): frozen tasks with pgpool #2264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
sylvlecl
changed the title
skamril
pushed a commit
that referenced
this pull request
Dec 11, 2024
This work aims at fixing issues encountered with load balanced pgpool, where a commit is not always instantly visible in another session (when read from replica). Fixes are: - restore a workaround which consists in re-trying the read until success - ensure exceptions occurring in the task execution thread are ALL caught Also removing a technical debt: - remove optional session from task job repo which was just used in tests. It did not work with code which uses both the repo and also the session from the singleton db.session. Signed-off-by: Sylvain Leclerc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #2263 on hotfix v2.18.2