Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(events): avoid slow processing of events #2259

Merged
merged 5 commits into from
Dec 2, 2024

Conversation

sylvlecl
Copy link
Member

@sylvlecl sylvlecl commented Dec 2, 2024

  • events are now retrieved in batch from redis, instead of 1 by 1
  • the event loop is only put at rest when it has nothing to process any more

- events are now retrieved in batch from redis,
  instead of 1 by 1
- the event loop is only put at rest when it has nothing to
  process any more

Signed-off-by: Sylvain Leclerc <[email protected]>
@sylvlecl sylvlecl marked this pull request as ready for review December 2, 2024 14:34
@sylvlecl
Copy link
Member Author

sylvlecl commented Dec 2, 2024

I could check in dev environment that it fixes the issue:

  • doing a GET synthesis on a variant study with 500 commands triggers a light generation with lots of events
  • triggering a timeseries generation just after

--> works as expected after the fix, and gets stuck before

@sylvlecl sylvlecl merged commit 316c6eb into hotfix/v2.18.1 Dec 2, 2024
10 checks passed
@sylvlecl sylvlecl deleted the fix/fix-websocket-events-transfer branch December 2, 2024 15:18
@makdeuneuv makdeuneuv added this to the v2.18.1 milestone Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants