feat(commands): add creation timestamp and user name inside commands #2252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinBelthle
requested changes
Nov 28, 2024
There was a problem hiding this comment.
I talked with Alexander and put the conclusion inside the JIRA ticket but basically wehave to do the conversion in the back from user_id to user name. Also ,we have to do it cleverly meaning if we retrieve 500 commands don't do 500 requests to have the user name but rather one for each individual user
alembic/versions/a8e9ee2cd4be_add_user_and_updated_date_info_to_.py
Outdated
Show resolved
Hide resolved
alembic/versions/a8e9ee2cd4be_add_user_and_updated_date_info_to_.py
Outdated
Show resolved
Hide resolved
maugde
changed the title
maugde
force-pushed
the
feat/ANT-1705-add-update-timestamp-for-studies
branch
from
0b25e3e to
8c840ba
Compare
MartinBelthle
requested changes
Dec 4, 2024
There was a problem hiding this comment.
The code seems okay but you'll have to add integration tests.
- Tests with 2 users altering the same study, you retrieve their names.
- Tests that one user appending two commands only call once the DB for user name
- Tests that it works with bots (add the test inside test_integration_token_end_to_end)
MartinBelthle
requested changes
Dec 6, 2024
…l, add migration file
…API, update tests
maugde
force-pushed
the
feat/ANT-1705-add-update-timestamp-for-studies
branch
from
ee86077 to
c5fd412
Compare
MartinBelthle
requested changes
Dec 10, 2024
…copy variant methods, update comments
MartinBelthle
changed the title
MartinBelthle
changed the title
MartinBelthle
approved these changes
Dec 11, 2024
MartinBelthle
deleted the
feat/ANT-1705-add-update-timestamp-for-studies
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve ANT-1705