Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(launcher): allow local launcher to work with xpress #2251

Open
wants to merge 27 commits into
base: dev
Choose a base branch
from

Conversation

MartinBelthle
Copy link
Contributor

@MartinBelthle MartinBelthle commented Nov 27, 2024

Will fix [ANT-2472]

Introduces few changes:

  • allow user to launch a simulation with xpress and presolve in local (tested by Alexander and it works)
  • use simulator 8.8.11 instead of 8.8.5
  • Don't import failed outputs inside the study
  • separate logs in stdout and stderr as it was done with the slurm launcher
  • Persist the logs if the simulation fails (by introducing a local_workspace)

@MartinBelthle MartinBelthle self-assigned this Nov 27, 2024
@MartinBelthle MartinBelthle force-pushed the feat/allow-xpress-and-presolve-in-local branch from 649422c to 4215f7e Compare November 29, 2024 09:30
@makdeuneuv makdeuneuv added this to the v2.18.2 milestone Dec 3, 2024
@pull-request-size pull-request-size bot added size/L and removed size/M labels Dec 11, 2024
Copy link
Member

@sylvlecl sylvlecl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main comments are about log management, as discussed

exc_info=e,
)
del self.job_id_to_study_id[str(uuid)]
if process.returncode == 0:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In slurm laucher we still call the import output when it has failed, we need to understand if it makes sense

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my understanding, if the simulator fails, the output is not retrieved from calin, therefore the _import_output fails. But with the local launcher the output exists and therefore it can be retrieved. I think we should keep the code as it is, else i would have to touch code shared with the slurm part

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Indeed if we still wanted to import the output, we should have some kind of status to say that it's a "failed output".

I wonder if we should not also delete the import output in slurm implementation, to clarify the behaviour ?

@MartinBelthle MartinBelthle force-pushed the feat/allow-xpress-and-presolve-in-local branch 2 times, most recently from ef11512 to ffcecd9 Compare December 18, 2024 10:38
Copy link
Member

@sylvlecl sylvlecl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good!

We need to do a few things for the desktop version:

  • adapt the config in resources/antares-desktop-fs
  • add the new empty directory in resources/antares-desktop-fs
  • we also need to write code in the installer to do the same thing to upgrade existing installations ...

@MartinBelthle MartinBelthle force-pushed the feat/allow-xpress-and-presolve-in-local branch from 4fce0ae to 6098d99 Compare December 19, 2024 09:20
@makdeuneuv makdeuneuv modified the milestones: v2.18.2, v2.18.4 Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants