feat(link): add update endpoint for link #2175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ink-update # Conflicts: # antarest/study/storage/variantstudy/model/command/create_link.py
MartinBelthle
requested changes
Nov 19, 2024
| @@ -198,6 +197,24 @@ def create_link( | |||
| params = RequestParameters(user=current_user) | |||
| return study_service.create_link(uuid, link_creation_info, params) | |||
|
|
|||
| @bp.put( | |||
| "/studies/{uuid}/links", | |||
There was a problem hiding this comment.
Okay. We should probably discuss what's a link id then. Is it area1%area2 or area1/area2 or another id ?
antarest/study/storage/variantstudy/model/command/create_link.py
Outdated
Show resolved
Hide resolved
antarest/study/storage/variantstudy/model/command/create_link.py
Outdated
Show resolved
Hide resolved
antarest/study/storage/variantstudy/model/command/create_link.py
Outdated
Show resolved
Hide resolved
MartinBelthle
requested changes
Nov 21, 2024
antarest/study/storage/variantstudy/model/command/update_link.py
Outdated
Show resolved
Hide resolved
MartinBelthle
requested changes
Nov 26, 2024
antarest/study/storage/variantstudy/model/command/create_link.py
Outdated
Show resolved
Hide resolved
antarest/study/storage/variantstudy/model/command/create_link.py
Outdated
Show resolved
Hide resolved
MartinBelthle
previously approved these changes
Nov 27, 2024
Added new linkDtoForUpdate object to hide area1 and area2 from the client
| @@ -78,6 +86,11 @@ def to_internal(self, version: StudyVersion) -> "LinkInternal": | |||
| return LinkInternal(**data) | |||
|
|
|||
|
|
|||
| class LinkDtoForUpdate(LinkDTO): | |||
| area1: SkipJsonSchema[str] = Field("a", exclude=True) | |||
There was a problem hiding this comment.
Weird way to do it. Why did you introduce fields a and b ?
There was a problem hiding this comment.
After testing this allows user to specfiy area1 and area2 inside the body and they we'll be ignored. I don't think we want that. I'd prefer you introduce a class that just has the base attributes and make LinkDTO inherit from this :/
| return self | ||
|
|
||
|
|
||
| class LinkDTO(Area): | ||
| model_config = ConfigDict(alias_generator=to_camel_case, populate_by_name=True, extra="forbid") | ||
| model_config = ConfigDict( |
There was a problem hiding this comment.
Could be in one line
| @@ -78,6 +86,11 @@ def to_internal(self, version: StudyVersion) -> "LinkInternal": | |||
| return LinkInternal(**data) | |||
|
|
|||
|
|
|||
| class LinkDtoForUpdate(LinkDTO): | |||
There was a problem hiding this comment.
Could be DTO instead of Dto to fit with existing class
MartinBelthle
approved these changes
Nov 28, 2024
TheoPascoli
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an endpoint to update link