Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: increase cleaning snapshot frequency #2173

Merged
merged 9 commits into from
Oct 9, 2024
Merged

feat: increase cleaning snapshot frequency #2173

merged 9 commits into from
Oct 9, 2024

Conversation

maugde
Copy link
Contributor

@maugde maugde commented Oct 7, 2024

PR for the ANT-1952 ticket.

  • add the option snapshot_lifespan in both configuration handlers and CONFIG.md
  • add test related to this operation

@maugde maugde force-pushed the feature/ANT-1952-increase-cleaning-snapshot-frequency branch from 5d6ba7a to 2706a8b Compare October 7, 2024 14:21
@maugde maugde self-assigned this Oct 7, 2024
@maugde maugde force-pushed the feature/ANT-1952-increase-cleaning-snapshot-frequency branch from 2706a8b to 9407129 Compare October 7, 2024 14:40
sylvlecl
sylvlecl requested changes Oct 7, 2024
View reviewed changes
Copy link
Member

@sylvlecl sylvlecl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just renaming suggestion for consistency sake with the cleaning endpoint we added recently

antarest/core/config.py Outdated Show resolved Hide resolved
antarest/study/storage/auto_archive_service.py Outdated Show resolved Hide resolved
docs/install/1-CONFIG.md Show resolved Hide resolved
MartinBelthle
MartinBelthle requested changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@MartinBelthle MartinBelthle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just little changes but seems good to me

antarest/study/storage/auto_archive_service.py Outdated Show resolved Hide resolved
antarest/core/config.py Outdated Show resolved Hide resolved
@MartinBelthle
Copy link
Contributor

Also don't forget to change the name when you'll merge your PR to respect the commit-lint

@pull-request-size pull-request-size bot added size/M and removed size/S labels Oct 8, 2024
@maugde maugde changed the title Feature/ant 1952 increase cleaning snapshot frequency feat: increase cleaning snapshot frequency Oct 8, 2024
@pull-request-size pull-request-size bot added size/L and removed size/M labels Oct 8, 2024
@maugde maugde force-pushed the feature/ANT-1952-increase-cleaning-snapshot-frequency branch from a41ac56 to e1e1e32 Compare October 8, 2024 12:10
@pull-request-size pull-request-size bot added size/M and removed size/L labels Oct 8, 2024
@sylvlecl sylvlecl merged commit 9562d09 into dev Oct 9, 2024
11 checks passed
@sylvlecl sylvlecl deleted the feature/ANT-1952-increase-cleaning-snapshot-frequency branch October 9, 2024 09:28
@makdeuneuv makdeuneuv added this to the v2.18 milestone Oct 24, 2024
@makdeuneuv makdeuneuv linked an issue Oct 24, 2024 that may be closed by this pull request
Variant snapshots should be cleaned way more often #1717
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinBelthle MartinBelthle MartinBelthle requested changes

@sylvlecl sylvlecl sylvlecl approved these changes

Assignees

@maugde maugde

Labels
size/M
Projects
None yet
Milestone
v2.18
Development

Successfully merging this pull request may close these issues.

Variant snapshots should be cleaned way more often
4 participants
@maugde @MartinBelthle @sylvlecl @makdeuneuv