fix: enable foreign keys for sqlite #2172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
MartinBelthle
previously approved these changes
Oct 7, 2024
| def _is_sqlite_connection(dbapi_connection: Any) -> bool: | ||
| cls = dbapi_connection.__class__ | ||
| full_classe_name = f"{cls.__module__}{cls.__name__}" | ||
| return "sqlite" in full_classe_name.lower() |
There was a problem hiding this comment.
I imagine there's not a way to do this in a cleaner way (check of class instance) :/ ?
There was a problem hiding this comment.
Check of class instance will be more fragile, this is kind of an implementation detail of sqlalchemy driver, I prefer being robust to any implementation change.
It's unlikely that another driver will have sqlite in its name.
There was a problem hiding this comment.
I changed the logic to depend on the driver name instead, it should be a little more reliable than class names.
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
sylvlecl
pushed a commit
that referenced
this pull request
Oct 11, 2024
This fixes the issue we encountered since PR #2172 where we couldn't delete studies on our local env or inside desktop version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, sqlite does not enforce foreign key constraints, this needs to be enabled explicitly.
This is in particular important to catch those errors in our unit tests, but also for
desktop mode.
Note
I have checked that indeed, tests before this fix did not pass.