feat(version): use class StudyVersion to handle versions #2156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinBelthle
force-pushed
the
feat/use-antares-study-version-widely
branch
from
959388a to
619946a
Compare
sylvlecl
reviewed
Sep 27, 2024
sylvlecl
reviewed
Sep 27, 2024
sylvlecl
reviewed
Sep 27, 2024
sylvlecl
reviewed
Sep 27, 2024
sylvlecl
reviewed
Oct 1, 2024
| version_to_write = f"{version:ddd}" | ||
| else: # should be written as X.Y | ||
| version_to_write = f"{version:2d}" | ||
| study_info["antares"]["solver_version"] = version_to_write |
There was a problem hiding this comment.
We need an evolution in antares-launcher to handle this correctly
sylvlecl
previously approved these changes
Oct 2, 2024
maugde
pushed a commit
that referenced
this pull request
Oct 7, 2024
This was referenced Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the class
StudyVersiondefined inside theantares-study-versionpackage to handle study versions widely inside the code.It allows users to import studies in v9.0.
It writes the version as 9.0 in the database (compared to 880 before)