Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(license): add a new ESLint rule to check license header #2150

Merged
merged 1 commit into from
Sep 19, 2024
Merged

chore(license): add a new ESLint rule to check license header #2150

merged 1 commit into from
Sep 19, 2024

Conversation

skamril
Copy link
Member

@skamril skamril commented Sep 19, 2024

No description provided.

@skamril skamril self-assigned this Sep 19, 2024
@skamril skamril changed the title chrore(license): add a new ESLint rule to check license header chore(license): add a new ESLint rule to check license header Sep 19, 2024
MartinBelthle
MartinBelthle previously approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@MartinBelthle MartinBelthle left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve as it seems okay even though I don't really understand everything. I'll let Hatim decide

@skamril skamril force-pushed the feature/license-header-eslint branch from 8bb5f5c to d09b433 Compare September 19, 2024 13:22
@skamril skamril force-pushed the feature/license-header-eslint branch from d09b433 to 3d32ed8 Compare September 19, 2024 13:23
@skamril skamril force-pushed the feature/license-header-eslint branch from 3d32ed8 to da6c55f Compare September 19, 2024 13:27
hdinia
hdinia requested changes Sep 19, 2024
View reviewed changes
Copy link
Member

@hdinia hdinia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you also commit the license-header.js file ?

webapp/.eslintrc.cjs Show resolved Hide resolved
@MartinBelthle
Copy link
Contributor

MartinBelthle commented Sep 19, 2024 •
edited
Loading

@hdinia I already merged the license-header.js file on dev in the last commit

@hdinia
Copy link
Member

hdinia commented Sep 19, 2024

@hdinia I already merged the license-header.js file on dev in the last commit

ok nice then

@skamril skamril merged commit 6a4bc9c into dev Sep 19, 2024
11 checks passed
@skamril skamril deleted the feature/license-header-eslint branch September 19, 2024 14:12
maugde pushed a commit that referenced this pull request Sep 26, 2024
@skamril @maugde
chore(license): add a new ESLint rule to check license header (#2150)
2ace8e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hdinia hdinia hdinia approved these changes

@MartinBelthle MartinBelthle MartinBelthle left review comments

Assignees

@skamril skamril

Labels
front-end size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skamril @MartinBelthle @hdinia