ci(tests): reduce number of workers for tests #2149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The use of as many workers as logical cores seems to cause significant increases of some monitored durations, including on Linux, which causes irrelevant CI failures. We revert to using as many workers as actual CPUs. Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
|
Nice the |
MartinBelthle
approved these changes
Sep 19, 2024
maugde
pushed a commit
that referenced
this pull request
Sep 26, 2024
The use of as many workers as logical cores seems to cause significant increases of some monitored durations, including on Linux, which causes irrelevant CI failures. We revert to using as many workers as actual CPUs. Also, load balancing of tests is improved using worksteal, which works far better with our tests which have very different execution times (integration tests are far longer than unit tests). --------- Signed-off-by: Sylvain Leclerc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of as many workers as logical cores
seems to cause significant increases of some
monitored durations, including on Linux, which
causes irrelevant CI failures.
We revert to using as many workers as actual CPUs.
Also, load balancing of tests is improved using worksteal,
which works far better with our tests which have very different
execution times (integration tests are far longer than unit tests).