feat(debug): allow files and folder deletion inside debug view #2147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinBelthle
force-pushed
the
feat/allow-files-deletion-in-debug-view
branch
from
cf2eb65 to
b2957c6
Compare
MartinBelthle
force-pushed
the
feat/allow-files-deletion-in-debug-view
branch
from
3285bad to
b9ec2a9
Compare
MartinBelthle
force-pushed
the
feat/allow-files-deletion-in-debug-view
branch
from
b9ec2a9 to
3853ea3
Compare
skamril
force-pushed
the
release/2.17.6
branch
from
95167ec to
7067134
Compare
skamril
force-pushed
the
feat/allow-files-deletion-in-debug-view
branch
from
3853ea3 to
03371bb
Compare
skamril
force-pushed
the
release/2.17.6
branch
from
7067134 to
3807b73
Compare
skamril
force-pushed
the
feat/allow-files-deletion-in-debug-view
branch
from
03371bb to
a0a01a5
Compare
skamril
force-pushed
the
release/2.17.6
branch
from
3807b73 to
f02fddb
Compare
skamril
force-pushed
the
feat/allow-files-deletion-in-debug-view
branch
2 times, most recently
from
5a29460 to
bf4ad31
Compare
sylvlecl
requested changes
Sep 24, 2024
antarest/study/service.py
Outdated
| url = [item for item in path.split("/") if item] | ||
| if len(url) < 2 or url[0] != "user": | ||
| raise FileDeletionNotAllowed(f"the targeted data isn't inside the 'User' folder: {path}") | ||
| if url[1] == "expansion": |
There was a problem hiding this comment.
We should probablu used registered files instead of hard coding it here
There was a problem hiding this comment.
I used RegisteredFile.
IMO it doesn't bring a lot as the behavior is still a bit hard coded but it has the merit of using the class and showing how for future devs.
MartinBelthle
force-pushed
the
feat/allow-files-deletion-in-debug-view
branch
from
81d55f2 to
e0fd6b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a new endpoint inside the back-end to fix [ANT-2083]
Samir will also add the front-end part
NB: I didn't specify inside the endpoint signature that it was for the User folder because I think we might use it for other folders such as the one for .yaml models that comes with Andromede modeling