feat(pydantic): use pydantic serialization #2139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
sylvlecl
reviewed
Sep 17, 2024
sylvlecl
reviewed
Sep 17, 2024
antarest/utils.py
Outdated
| services["cache"] = cache | ||
| services["maintenance"] = maintenance_service | ||
| return services | ||
| def to_json(data: t.Any, indent: t.Optional[int] = None) -> bytes: |
There was a problem hiding this comment.
What would you think about moving this to a core.serialization module ? Something more targetted than the plain "utils".
Also we should add a docstring to mention that we do this to benefit from the performances of pydantic serialization
sylvlecl
reviewed
Sep 17, 2024
|
Indeed I was lazy |
sylvlecl
approved these changes
Sep 17, 2024
maugde
pushed a commit
that referenced
this pull request
Sep 26, 2024
This will allow to benefit from improved serialization performances of pydantic v2, even for non-pydantic classes. fix [ANT-2052]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix [ANT-2052]