-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: parallel pytest execution #2131
Conversation
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
This reverts commit 200a8a7.
Signed-off-by: Sylvain Leclerc <[email protected]>
This reverts commit 6eb8469.
Signed-off-by: Sylvain Leclerc <[email protected]>
Signed-off-by: Sylvain Leclerc <[email protected]>
antarest/login/auth.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have an idea why this was not corrected by isort
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually there is no change on import sort order in the final PR. Intermediate commits introduced unwanted changes (related to another PR).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- For the
rebase
it should be launched locally (always). - The
commit
messages should be corrected. - The branch naming does not respect the
git flow
we fixed.
Closed in favor of #2133 which fixes naming issues |
Experiment the use of pytest-xdist to speed up test execution in CI and dev environment:
see for example this job where tests are executed in under 10min on ubuntu.
Following issues with parallel execution of tests are solved :
disk_usage
, which was anyway not a good idea (dependent on what happens elsewhere on the machine). It's now replaced with mockingcommand_factory
test checked something in its teardown, assuming all tests were executed in the same process, which is not the case anymore. The same check is done as a separate unit tests.