ci(github): update workflows #2121
+103
−20
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,47 @@ | ||
| name: main | ||
|
|
||
| # If a workflow is skipped due to path filtering, branch filtering or a commit message, | ||
| # then checks associated with that workflow will remain in a "Pending" state. | ||
| # A pull request that requires those checks to be successful will be blocked from merging. | ||
| # | ||
| # So we use conditions to control job execution (`if: ...`) instead of `pull_request` event parameters. | ||
| # A job that is skipped will report its status as "Success". | ||
| # It will not prevent a pull request from merging, even if it is a required check. | ||
| on: [pull_request] | ||
|
|
||
| jobs: | ||
|
|
||
| ################################################################ | ||
| ## Back-end | ||
| ################################################################ | ||
|
|
||
| detect-backend-changes: | ||
| runs-on: ubuntu-20.04 | ||
| outputs: | ||
| has-changes: ${{ steps.detect-changes.outputs.has-changes }} | ||
| steps: | ||
| - name: Checkout GitHub repo | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 # Ensure full history is fetched | ||
| - name: Check if backend files have changed | ||
| id: detect-changes | ||
| run: | | ||
| git fetch origin ${{ github.event.pull_request.base.ref }} --depth=1 | ||
| if git diff --name-only origin/${{ github.event.pull_request.base.ref }}...HEAD | grep -Eq '^antarest/|^tests/|^resources/|^requirements.*\.txt$'; then | ||
|
There was a problem hiding this comment. The build will be affected by other configuration files (setup files, pyproject.toml, maybe alembic configuration too...): to be checked |
||
| echo "Backend files have changed" | ||
| echo "has-changes=true" >> $GITHUB_OUTPUT | ||
| else | ||
| echo "No backend files have changed" | ||
| echo "has-changes=false" >> $GITHUB_OUTPUT | ||
| fi | ||
|
|
||
| python-lint: | ||
| needs: detect-backend-changes | ||
| if: ${{ needs.detect-backend-changes.outputs.has-changes == 'true' }} | ||
| runs-on: ubuntu-20.04 | ||
| steps: | ||
| - name: Checkout GitHub repo (+ download lfs dependencies) | ||
| uses: actions/checkout@v4 | ||
| - name: Set up Python | ||
| uses: actions/setup-python@v5 | ||
|
|
@@ -34,14 +67,15 @@ jobs: | |
| mypy --install-types --non-interactive | ||
|
|
||
| python-test: | ||
| needs: detect-backend-changes | ||
| if: ${{ needs.detect-backend-changes.outputs.has-changes == 'true' }} | ||
| runs-on: ${{ matrix.os }} | ||
| strategy: | ||
| max-parallel: 9 | ||
| matrix: | ||
| os: [windows-latest, ubuntu-20.04] | ||
| steps: | ||
| - name: Checkout GitHub repo (+ download lfs dependencies) | ||
| uses: actions/checkout@v4 | ||
| - name: Set up Python | ||
| uses: actions/setup-python@v5 | ||
|
|
@@ -61,10 +95,50 @@ jobs: | |
| name: python-code-coverage-report | ||
| path: coverage.xml | ||
|
|
||
| python-tests: | ||
| needs: [detect-backend-changes, python-test] | ||
| if: ${{ needs.detect-backend-changes.outputs.has-changes == 'true' && always() }} | ||
| runs-on: ubuntu-20.04 | ||
| steps: | ||
| - name: Results of Python tests by OS | ||
| run: exit 1 | ||
| # See https://stackoverflow.com/a/67532120/4907315 | ||
| if: >- | ||
| ${{ | ||
| contains(needs.*.result, 'failure') | ||
| || contains(needs.*.result, 'cancelled') }} | ||
|
|
||
| ################################################################ | ||
| ## Front-end | ||
| ################################################################ | ||
|
|
||
| detect-frontend-changes: | ||
| runs-on: ubuntu-20.04 | ||
| outputs: | ||
| has-changes: ${{ steps.detect-changes.outputs.has-changes }} | ||
| steps: | ||
| - name: Checkout GitHub repo | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| fetch-depth: 0 # Ensure full history is fetched | ||
| - name: Check if front-end files have changed | ||
| id: detect-changes | ||
| run: | | ||
| git fetch origin ${{ github.event.pull_request.base.ref }} --depth=1 | ||
| if git diff --name-only origin/${{ github.event.pull_request.base.ref }}...HEAD | grep -q '^webapp/'; then | ||
| echo "Front-end files have changed" | ||
| echo "has-changes=true" >> $GITHUB_OUTPUT | ||
| else | ||
| echo "No front-end files in have changed" | ||
| echo "has-changes=false" >> $GITHUB_OUTPUT | ||
| fi | ||
|
|
||
| npm-setup: | ||
| needs: detect-frontend-changes | ||
| if: ${{ needs.detect-frontend-changes.outputs.has-changes == 'true' }} | ||
| runs-on: ubuntu-20.04 | ||
| steps: | ||
| - name: Checkout GitHub repo | ||
| uses: actions/checkout@v4 | ||
| - name: Set up Node.js | ||
| uses: actions/setup-node@v4 | ||
|
|
@@ -87,7 +161,7 @@ jobs: | |
| needs: npm-setup | ||
| runs-on: ubuntu-20.04 | ||
| steps: | ||
| - name: Checkout GitHub repo | ||
| uses: actions/checkout@v4 | ||
| - name: Set up Node.js | ||
| uses: actions/setup-node@v4 | ||
|
|
@@ -107,7 +181,7 @@ jobs: | |
| needs: npm-setup | ||
| runs-on: ubuntu-20.04 | ||
| steps: | ||
| - name: Checkout GitHub repo | ||
| uses: actions/checkout@v4 | ||
| - name: Set up Node.js | ||
| uses: actions/setup-node@v4 | ||
|
|
@@ -127,7 +201,7 @@ jobs: | |
| needs: npm-setup | ||
| runs-on: ubuntu-20.04 | ||
| steps: | ||
| - name: Checkout GitHub repo | ||
| uses: actions/checkout@v4 | ||
| - name: Set up Node.js | ||
| uses: actions/setup-node@v4 | ||
|
|
@@ -146,17 +220,24 @@ jobs: | |
| NODE_OPTIONS: --max-old-space-size=8192 | ||
| DISABLE_ESLINT_PLUGIN: true | ||
|
|
||
| ################################################################ | ||
| ## SonarCloud | ||
| ################################################################ | ||
|
|
||
| sonarcloud: | ||
| if: ${{ always() }} | ||
| needs: [python-test, npm-test] | ||
| runs-on: ubuntu-20.04 | ||
| steps: | ||
| - name: Checkout GitHub repo | ||
| uses: actions/checkout@v4 | ||
| - name: Download python coverage report | ||
| uses: actions/download-artifact@v4 | ||
| with: | ||
| name: python-code-coverage-report | ||
| # Config in `sonar-project.properties` file | ||
| - name: SonarCloud Scan | ||
| uses: sonarsource/[email protected] | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running this workflow on pull requests will not be enough:
we still want all tests and sonarcloud to be run on main and dev branches when we merge into them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A pull request must be open to merge into
devandmaster(branch protection rules), soon: [pull_request]is enough here.